PYTHON-2605: Improve mongodb+srv:// error message when dnspython is not installed #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Apr 23, 2021
pymongo/uri_parser.py
Outdated
| scheme_free = uri[SCHEME_LEN:] | ||
| elif uri.startswith(SRV_SCHEME): | ||
| if not _HAVE_DNSPYTHON: | ||
| python_path = os.getenv('_', "python") |
Member
There was a problem hiding this comment.
Instead of os.getenv let's use sys.executable like this:
python_path = sys.executable or 'python'
pymongo/uri_parser.py
Outdated
| 'To fix this error install pymongo ' | ||
| 'with the srv extra:\n ' | ||
| '%s -m pip install "pymongo[srv]"' | ||
| % (python_path)) |
Member
There was a problem hiding this comment.
We could make this more readable by formatting like this:
raise ConfigurationError(
'The "dnspython" module must be installed to use '
'mongodb+srv:// URIs. To fix this error...'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note for reviewers
osonly for the path seems a bit excessive. But let me know if you would like me to change it :)